Skip to content

Disable the coordinator write omission in ScalarDB #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

Disable the coordinator write omission in ScalarDB #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b6258b
Disable the coordinator write omission in ScalarDB
jnmt Jul 24, 2025
4251f0a
Fix based on feedback from Gemini
jnmt Jul 24, 2025
941a42c
Update ledger/src/main/java/com/scalar/dl/ledger/config/LedgerConfig.…
jnmt Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ledger/src/main/java/com/scalar/dl/ledger/config/LedgerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,14 @@ private void validateTransactionManager() {
LedgerError.CONFIG_GROUP_COMMIT_MUST_BE_DISABLED.buildMessage(
ConsensusCommitConfig.COORDINATOR_GROUP_COMMIT_ENABLED));
}
if (consensusCommitConfig.isCoordinatorWriteOmissionOnReadOnlyEnabled()) {
LOGGER.warn(
"Disabling the unsupported option '{}' because Coordinator writes are always necessary for ScalarDL",
ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED);
props.setProperty(
ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED,
Boolean.toString(false));
}
}
}

Expand Down
34 changes: 34 additions & 0 deletions ledger/src/test/java/com/scalar/dl/ledger/config/LedgerConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,4 +581,38 @@ public void constructor_HmacEnabledButCipherKeyNotGiven_ShouldThrowIllegalArgume
// Assert
assertThat(thrown).isExactlyInstanceOf(IllegalArgumentException.class);
}

@Test
public void
constructor_ConsensusCommitWithCoordinatorWriteOmissionDisabledSpecified_ShouldConstructProperly() {
// Arrange
props.setProperty(DatabaseConfig.TRANSACTION_MANAGER, "consensus-commit");
props.setProperty(
ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED, "false");

// Act
LedgerConfig config = new LedgerConfig(props);
ConsensusCommitConfig consensusCommitConfig =
new ConsensusCommitConfig(config.getDatabaseConfig());

// Assert
assertThat(consensusCommitConfig.isCoordinatorWriteOmissionOnReadOnlyEnabled()).isFalse();
}

@Test
public void
constructor_ConsensusCommitWithCoordinatorWriteOmissionEnabledSpecified_ShouldConstructProperlyWithDisablingIt() {
// Arrange
props.setProperty(DatabaseConfig.TRANSACTION_MANAGER, "consensus-commit");
props.setProperty(
ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED, "true");

// Act
LedgerConfig config = new LedgerConfig(props);
ConsensusCommitConfig consensusCommitConfig =
new ConsensusCommitConfig(config.getDatabaseConfig());

// Assert
assertThat(consensusCommitConfig.isCoordinatorWriteOmissionOnReadOnlyEnabled()).isFalse();
}
}