Backport to branch(3) : Disable the coordinator write omission in ScalarDB

[jnmt]

Backport of #203.

[gemini-code-assist]

Summary of Changes

Hello @jnmt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures that the 'coordinator write omission on read-only' feature is always disabled within ScalarDL's Ledger component, as it's a necessary operation for the system's integrity. It includes both the enforcement logic and corresponding unit tests to validate this behavior.

Highlights

• Configuration Enforcement: Modified LedgerConfig.java to explicitly disable the COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED setting if it's found to be enabled. A warning is logged, indicating that this option is unsupported and coordinator writes are always necessary for ScalarDL.
• Unit Testing: Added two new test cases in LedgerConfigTest.java to verify that the coordinatorWriteOmissionOnReadOnlyEnabled property is correctly set to false by the system, regardless of whether it was initially configured as true or false.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables the coordinator write omission feature in ScalarDB when used with ScalarDL. The implementation includes a warning message and overrides the setting. The change is supported by unit tests. The review suggests simplifying the logic by removing the conditional check before disabling the feature.

[gemini-code-assist]

It is redundant to check if consensusCommitConfig.isCoordinatorWriteOmissionOnReadOnlyEnabled() is true and then immediately disable it. The property can be directly set to false without the conditional check, simplifying the logic.

        LOGGER.warn(
            "Disabling the unsupported option '{}' because Coordinator writes are always necessary for ScalarDL",
            ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED);
        props.setProperty(
            ConsensusCommitConfig.COORDINATOR_WRITE_OMISSION_ON_READ_ONLY_ENABLED,
            Boolean.toString(false));