Fix null condition handling #238
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a NullPointerException that occurred in table-oriented generic contracts when handling IS NULL or IS NOT NULL conditions. The fix involves adjusting the condition parsing logic to correctly handle these operators, which do not have an associated value field, thereby preventing the NPE. Additionally, the PR introduces a new common-test module to centralize test utilities and dependencies.
Highlights
- Bug Fix for Null Conditions: Resolved a NullPointerException that arose when processing IS_NULL or IS_NOT_NULL conditions in generic contracts, by ensuring the value field is not accessed for these operator types.
- Refactored Condition Parsing: Modified the isPrimaryKeyCondition and isIndexKeyCondition methods in Scan.java to correctly validate and process conditions based on their operator type, preventing erroneous attempts to read non-existent value fields.
- Centralized Test Utilities: Introduced a new Gradle module, common-test, to consolidate shared test fixtures and dependencies, improving modularity and reusability across projects.
- Enhanced Test Coverage: Added new unit tests in ScanTest.java to specifically verify the correct handling and error scenarios for IS_NULL and IS_NOT_NULL conditions on primary and index keys.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a NullPointerException that occurred with IS_NULL or IS_NOT_NULL conditions by checking the operator before accessing the condition's value. The added tests in ScanTest.java correctly verify this fix. Additionally, the refactoring of test utilities into a new common-test module is a good improvement for code organization and maintainability. I have one minor suggestion to simplify some conditional logic for better readability.
generic-contracts/src/main/java/com/scalar/dl/genericcontracts/table/v1_0_0/Scan.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null pointer exception bug that occurs when handling IS_NULL or IS_NOT_NULL conditions in table-oriented generic contracts. The issue was that the code attempted to access the value field for these operators, which don't have one.
- Added operator type validation before accessing condition values
- Updated primary key and index key condition validation logic
- Added comprehensive test coverage for IS_NULL and IS_NOT_NULL scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Scan.java | Fixed condition validation logic to check operator type before accessing value field |
| ScanTest.java | Added test cases for IS_NULL and IS_NOT_NULL condition handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
generic-contracts/src/main/java/com/scalar/dl/genericcontracts/table/v1_0_0/Scan.java
Show resolved
Hide resolved
Description
This PR fixes a bug that throws NPE when a condition is IS_NULL or IS_NOT_NULL, since they don't have the
valuefield.Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
Release notes
Fixed
IS NULLandIS NOT NULLconditions handling in table-oriented generic contracts.