Fix to avoid using test-fixtures plugin #237
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the project's build configuration by eliminating the direct use of the java-test-fixtures Gradle plugin. It introduces a new common-test module to centralize shared test utilities and dependencies, improving modularity and simplifying test setup across different project components.
Highlights
- Build System Refactoring: The 'java-test-fixtures' plugin has been removed from the 'client' module's build configuration, streamlining the build process.
- New Common Test Module: A new Gradle module named 'common-test' has been introduced to consolidate shared test-related code and dependencies, promoting reusability and maintainability.
- Test Utility Relocation: The 'CommandLineTestUtils.java' file, previously located in 'client/src/testFixtures', has been relocated to the new 'common-test' module, centralizing common test utilities.
- Dependency Updates: Other modules, specifically 'client' and 'table-store', have been updated to depend on the new 'common-test' module for their testing needs, simplifying their build configurations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to remove the java-test-fixtures plugin by introducing a new common-test module. While this is a good direction, the new module's Gradle build file (common-test/build.gradle) has a couple of critical issues. It's missing the java-library plugin, which is necessary to compile its Java code. More importantly, it introduces a circular dependency with the client module, which is a significant architectural problem. Both of these issues need to be resolved to ensure a correct and maintainable build.
Description
This PR fixes the configuration for the common test utilities to avoid using the test-fixtures plugin introduced recently. The test-fixtures plugin has an issue that it automatically includes the dependency for the module itself (scalardl-java-client-sdk) by default, which results in a circular reference and release failure. We don't have to stick to this plugin if we just use the utilities among submodules. So, this PR stops using it.
Note that the
common-testmodule will also be used as a place to have integration test bases that will be introduced in an upcoming PR.Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A