Backport to branch(3) : Fix to avoid using test-fixtures plugin

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix to avoid using test-fixtures plugin #237
• Backported commit: e94b88a

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's build system by creating a dedicated common-test Gradle module. This change aims to consolidate and centralize shared test-related code and dependencies, moving them out of individual modules like client to improve modularity and maintainability across the codebase.

Highlights

• Refactoring Test Infrastructure: The project's test infrastructure has been refactored by introducing a new common-test Gradle module. This centralizes shared test utilities and dependencies.
• Removal of java-test-fixtures Plugin: The client module no longer uses the java-test-fixtures plugin, as its functionality and related code have been migrated to the new common-test module.
• Centralized Test Dependencies: Common test dependencies, such as picocli, assertj-core, and junit-jupiter, are now managed within the common-test/build.gradle file, promoting reusability and consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a backport that refactors the build process to remove the java-test-fixtures plugin and introduces a new common-test module for shared test utilities. This is a positive change for the project's structure and maintainability. I've provided a couple of suggestions for the new common-test/build.gradle file to enhance dependency management and consistency.

[gemini-code-assist]

The new common-test module is a library for test utilities. To correctly expose its dependencies to consumer modules, it should use the java-library plugin and the api dependency configuration.

1. Apply java-library plugin: This plugin should be applied to enable the api and implementation configurations for better dependency management.
2. Use api for exposed dependencies:
   • picocli: Its types are used in the public API of CommandLineTestUtils, so it must be an api dependency.
   • junit-jupiter-api: This should also be an api dependency so that projects using common-test can use JUnit APIs for their tests without declaring the dependency themselves.

plugins {
    id 'java-library'
    id 'net.ltgt.errorprone' version "${errorpronePluginVersion}"
    id "com.github.spotbugs" version "${spotbugsPluginVersion}"
}

dependencies {
    implementation project(':client')
    api group: 'info.picocli', name: 'picocli', version: "${picoCliVersion}"
    implementation group: 'org.assertj', name: 'assertj-core', version: "${assertjVersion}"
    api group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: "${junitVersion}"
    runtimeOnly group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: "${junitVersion}"

[gemini-code-assist]

For consistency with other modules (like client) and for better maintainability, please use the googleJavaFormatVersion project property instead of hardcoding the version '1.7'. This ensures that all modules use the same version of the formatter and it can be updated in one place.

        googleJavaFormat(googleJavaFormatVersion)