fix: cron regex #1079
Merged
fix: cron regex #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambo-e
suggested changes
Nov 17, 2022
Contributor
chambo-e
left a comment
chambo-e
left a comment
There was a problem hiding this comment.
Could you also add some tests matching the new regex ? :)
QuiiBz
approved these changes
Nov 17, 2022
Contributor
Author
|
done @chambo-e |
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 23 23
Lines 584 584
Branches 80 80
=======================================
Hits 583 583
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chambo-e
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct cron regex