fix: bad condition inside handleRequest #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
force-pushed
the
fix/use-dataloader-key-checking
branch
from
354b8d6 to
420cced
Compare
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 265 263 -2
Branches 41 40 -1
=========================================
- Hits 265 263 -2
Continue to review full report at Codecov.
|
chambo-e
approved these changes
May 10, 2021
matthprost
approved these changes
May 10, 2021
DorianMaliszewski
force-pushed
the
fix/use-dataloader-key-checking
branch
from
420cced to
1211bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the key in isLoading state it cause no data and no reload :/