feat(i18n): add loaded namespaces and isLoaded into useTranslation #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philibea
force-pushed
the
i18n-namespaces-loaded
branch
2 times, most recently
from
ef3c436 to
73e42c3
Compare
philibea
force-pushed
the
i18n-namespaces-loaded
branch
from
73e42c3 to
c4d9fac
Compare
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 264 267 +3
Branches 39 39
=========================================
+ Hits 264 267 +3
Continue to review full report at Codecov.
|
philibea
changed the title
philibea
changed the title
philibea
force-pushed
the
i18n-namespaces-loaded
branch
from
c4d9fac to
a047eb5
Compare
philibea
changed the title
philibea
force-pushed
the
i18n-namespaces-loaded
branch
from
27bad93 to
ba6085f
Compare
chambo-e
reviewed
May 19, 2021
vincentaudebert
approved these changes
May 19, 2021
philibea
force-pushed
the
i18n-namespaces-loaded
branch
from
ba6085f to
3636333
Compare
philibea
force-pushed
the
i18n-namespaces-loaded
branch
from
3636333 to
56807b1
Compare
chambo-e
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new state namespaces on Provider, this state re-present namespace that are already loaded.
Add isLoaded on useTranslation hook, this params will help to avoid multi-rerender when it's not needed.
Add ReactDom unstable_batchedUpdates to minimize number of renders