Skip to content

feat: use dataloader handle enabled changes #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

feat: use dataloader handle enabled changes #196

merged 1 commit into from
May 25, 2021

Conversation

@DorianMaliszewski
Copy link
Member

@DorianMaliszewski DorianMaliszewski commented May 25, 2021 •
edited
Loading

What I did

  • Optimization of hooks rerender by using some refs
  • Handle enabled change and key change better

@DorianMaliszewski DorianMaliszewski added enhancement New feature or request performance labels May 25, 2021
@DorianMaliszewski DorianMaliszewski self-assigned this May 25, 2021
@DorianMaliszewski DorianMaliszewski force-pushed the feat/use-dataloader-improvement-usability branch from 46bb820 to 84e3679 Compare May 25, 2021 09:43
matthprost
matthprost suggested changes May 25, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented May 25, 2021 •
edited
Loading

Codecov Report

Merging #196 (be867d6) into master (dc137f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          267       270    +3     
  Branches        39        38    -1     
=========================================
+ Hits           267       270    +3
Impacted Files Coverage Δ
packages/use-dataloader/src/useDataLoader.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc137f4...be867d6. Read the comment docs.

@DorianMaliszewski DorianMaliszewski force-pushed the feat/use-dataloader-improvement-usability branch from 84e3679 to be867d6 Compare May 25, 2021 09:56
chambo-e
chambo-e approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@DorianMaliszewski DorianMaliszewski merged commit 644ddb7 into master May 25, 2021
@DorianMaliszewski DorianMaliszewski deleted the feat/use-dataloader-improvement-usability branch May 25, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philibea philibea Awaiting requested review from philibea

2 more reviewers

@chambo-e chambo-e chambo-e approved these changes

@matthprost matthprost matthprost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DorianMaliszewski DorianMaliszewski

Labels

enhancement New feature or request performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DorianMaliszewski @chambo-e @matthprost