feat: concurrent request handle with dataloader #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
requested review from
adriengibrat,
chambo-e,
matthprost,
philibea and
vincentaudebert
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
0cb1991 to
518a916
Compare
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 360 414 +54
Branches 60 66 +6
=========================================
+ Hits 360 414 +54
Continue to review full report at Codecov.
|
matthprost
suggested changes
Sep 21, 2021
matthprost
suggested changes
Sep 21, 2021
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
2 times, most recently
from
dda4ec0 to
33c2212
Compare
matthprost
suggested changes
Sep 22, 2021
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
33c2212 to
601fd98
Compare
matthprost
suggested changes
Sep 22, 2021
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
601fd98 to
9fc35aa
Compare
matthprost
approved these changes
Sep 23, 2021
chambo-e
reviewed
Sep 27, 2021
packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx
Outdated
Show resolved
Hide resolved
adriengibrat
suggested changes
Sep 27, 2021
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
9fc35aa to
da96db9
Compare
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
da96db9 to
c5663f5
Compare
DorianMaliszewski
force-pushed
the
feat/concurrent-request-handle
branch
from
c5663f5 to
74be2e8
Compare
vincentaudebert
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle when there multiple same request to avoid multiple same promise resolution.