feat: refresh data on max lifetime reached #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
requested review from
adriengibrat,
chambo-e,
matthprost,
philibea and
vincentaudebert
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 414 432 +18
Branches 66 72 +6
=========================================
+ Hits 414 432 +18
Continue to review full report at Codecov.
|
matthprost
suggested changes
Sep 27, 2021
DorianMaliszewski
force-pushed
the
feat/use-dataloader-stalled-data
branch
from
92d3191 to
26d8f5f
Compare
matthprost
suggested changes
Sep 27, 2021
adriengibrat
approved these changes
Sep 27, 2021
chambo-e
approved these changes
Sep 28, 2021
DorianMaliszewski
force-pushed
the
feat/use-dataloader-stalled-data
branch
2 times, most recently
from
44f0cec to
d96e840
Compare
DorianMaliszewski
force-pushed
the
feat/use-dataloader-stalled-data
branch
from
d96e840 to
c509dd1
Compare
matthprost
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider data as outdated when maxLifetime is reached. Allow stalled data detection when there are multiple useDataLoader with same key. (Performance)