feat: max concurrent request usedataloader #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
requested review from
adriengibrat,
chambo-e,
matthprost,
philibea and
vincentaudebert
QuiiBz
reviewed
Oct 4, 2021
DorianMaliszewski
force-pushed
the
feat/max-concurrent-requests
branch
from
7ef3d2a to
dc042ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 432 448 +16
Branches 72 71 -1
=========================================
+ Hits 432 448 +16
Continue to review full report at Codecov.
|
adriengibrat
reviewed
Oct 4, 2021
adriengibrat
reviewed
Oct 4, 2021
DorianMaliszewski
force-pushed
the
feat/max-concurrent-requests
branch
4 times, most recently
from
709693c to
3225c22
Compare
adriengibrat
approved these changes
Oct 5, 2021
vincentaudebert
requested changes
Oct 6, 2021
Contributor
vincentaudebert
left a comment
vincentaudebert
left a comment
There was a problem hiding this comment.
Just checking but is the doc/readme up to date with this new param? Could be cool to have some info about it.
matthprost
suggested changes
Oct 7, 2021
matthprost
approved these changes
Oct 8, 2021
Contributor
matthprost
left a comment
matthprost
left a comment
There was a problem hiding this comment.
Except my up comment everything seems fine I'm validating
DorianMaliszewski
force-pushed
the
feat/max-concurrent-requests
branch
from
507f8c7 to
b145511
Compare
DorianMaliszewski
force-pushed
the
feat/max-concurrent-requests
branch
from
b145511 to
e5f5155
Compare
DorianMaliszewski
force-pushed
the
feat/max-concurrent-requests
branch
from
e5f5155 to
46a988b
Compare
vincentaudebert
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to set max concurrent dataloader in parallel