fix: useeffect that handle enable change #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
requested review from
chambo-e,
matthprost,
philibea and
vincentaudebert
DorianMaliszewski
force-pushed
the
fix/enable-use-effect
branch
from
ad32a41 to
48e784b
Compare
DorianMaliszewski
force-pushed
the
fix/enable-use-effect
branch
from
48e784b to
2a96768
Compare
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 473 476 +3
Branches 75 76 +1
=========================================
+ Hits 473 476 +3
Continue to review full report at Codecov.
|
Member
Author
|
I add a Promise with empty setTimeout because worker are too fast to launch then go into expect |
chambo-e
approved these changes
Oct 19, 2021
matthprost
approved these changes
Oct 19, 2021
vincentaudebert
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when enabled change from false to true and the request is IDLE, then launch it