feat: add needPolling callback #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 484 492 +8
Branches 78 81 +3
=========================================
+ Hits 484 492 +8
Continue to review full report at Codecov.
|
DorianMaliszewski
force-pushed
the
feat/polling-callback
branch
from
8975c88 to
f7a0e17
Compare
chambo-e
approved these changes
Nov 30, 2021
DorianMaliszewski
requested review from
QuiiBz,
matthprost and
vincentaudebert
QuiiBz
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to pass a callback function that return a boolean to tell if we enable or not the polling (Allow us to drop local useState to manage this)