feat(segment): add on event error to handle all your events from prov… #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philibea
force-pushed
the
segment-add-onEventError
branch
from
18354fc to
932c715
Compare
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 529 529
Branches 90 90
=========================================
Hits 529 529
Continue to review full report at Codecov.
|
philibea
force-pushed
the
segment-add-onEventError
branch
from
932c715 to
93f3b54
Compare
chambo-e
reviewed
Jan 18, 2022
Contributor
chambo-e
left a comment
chambo-e
left a comment
There was a problem hiding this comment.
I don't really understand the gain of having a centralised way of handling this in the provider, a custom wrapper by the user would be equivalent no ?
philibea
force-pushed
the
segment-add-onEventError
branch
from
93f3b54 to
38718a0
Compare
DorianMaliszewski
approved these changes
Jan 18, 2022
matthprost
approved these changes
Jan 20, 2022
chambo-e
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ider