feat: add alphaLower and basicDomain regex #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 527 529 +2
Branches 90 90
=========================================
+ Hits 527 529 +2
Continue to review full report at Codecov.
|
philibea
requested review from
a team,
DorianMaliszewski and
matthprost
and removed request for
a team
adriengibrat
force-pushed
the
feature/regex_alpha_lower_basic_domain
branch
from
6d6d4c1 to
fdcc311
Compare
philibea
approved these changes
Jan 19, 2022
QuiiBz
approved these changes
Jan 19, 2022
matthprost
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alphaLower & basicDomain regex to
@scaleway/regexpackage + tests