Skip to content

Conversation

@philibea
Copy link
Collaborator

@philibea philibea commented Apr 1, 2022

It's will possibly improve the size on all bundle using react, but we will be more coherent with all ours projects

@philibea philibea force-pushed the preset-react-runtime branch from f974a57 to 65ab9a9 Compare April 1, 2022 12:38
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #695 (c7700a9) into main (f578985) will not change coverage.
The diff coverage is n/a.

❗ Current head c7700a9 differs from pull request most recent head 2375b05. Consider uploading reports for the commit 2375b05 to get more accurate results

@@            Coverage Diff            @@
##              main      #695   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          535       535           
  Branches        83        83           
=========================================
  Hits           535       535           
Impacted Files Coverage Δ
...kages/jest-helpers/src/helpers/renderWithTheme.tsx 100.00% <ø> (ø)
packages/use-dataloader/src/DataLoaderProvider.tsx 100.00% <ø> (ø)
packages/use-i18n/src/usei18n.tsx 100.00% <ø> (ø)
packages/use-segment/src/useSegment.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f578985...2375b05. Read the comment docs.

@QuiiBz
Copy link
Contributor

QuiiBz commented Apr 1, 2022

Should we disable the react/react-in-jsx-scope rule? ESLint don't like it:

https://github.com/scaleway/scaleway-lib/runs/5787900573?check_suite_focus=true#step:7:12

@philibea philibea force-pushed the preset-react-runtime branch 2 times, most recently from 2e154b2 to e554b75 Compare April 1, 2022 13:09
@philibea
Copy link
Collaborator Author

philibea commented Apr 1, 2022

Should we disable the react/react-in-jsx-scope rule? ESLint don't like it:

https://github.com/scaleway/scaleway-lib/runs/5787900573?check_suite_focus=true#step:7:12

yes exactly, it's already done

@philibea philibea requested review from a team, QuiiBz and adriengibrat and removed request for a team April 1, 2022 13:12
@philibea philibea self-assigned this Apr 1, 2022
@philibea philibea added enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 1, 2022
@philibea philibea force-pushed the preset-react-runtime branch from ef67373 to 0dbfdb0 Compare April 5, 2022 10:22
@philibea philibea requested a review from chambo-e April 5, 2022 10:23
@philibea philibea force-pushed the preset-react-runtime branch from 0dbfdb0 to 7dad1b1 Compare April 5, 2022 10:23
@philibea philibea enabled auto-merge (squash) April 5, 2022 13:56
@philibea philibea merged commit 8238a62 into main Apr 5, 2022
@philibea philibea deleted the preset-react-runtime branch April 5, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants