Version release 0.4 #132
Merged
Version release 0.4 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EEGDashDataset` class had an inconsistency in its `__init__` method regarding the `cache_dir` parameter. The method signature made it a required positional argument, but the docstring and implementation logic implied it was optional with a fallback to a default directory.
This commit resolves the inconsistency by making the parameter behavior align with it being mandatory:
1. The implementation is simplified to `self.cache_dir = Path(cache_dir)`, removing the misleading `or get_default_cache_dir()` fallback.
2. The docstring for `cache_dir` is updated to remove the mention of it being optional.
3. A new test case is added to `tests/test_api.py` to verify that passing an empty string for `cache_dir` now correctly resolves to the current directory (`.`), which is the behavior of `Path("")`. This confirms the removal of the old fallback logic.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ub.com/sccn/EEGDash into refactor-load_eeg_attrs_from_bids_file
[BUG] Update environment configuration for caching in the CI
[DOC] Fix cache dir inconsistency
fix to better unicode
docs: add manual API reference
[EHN] Use BIDSPath to resolve EEG sidecars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.