ModuleRunner: use the log, not status, upon error

ctrueden · ctrueden · commit 3b6c40a30302 · 2023-05-11T15:06:47.000-05:00
The log is for exceptional conditions, whereas
the status reporting mechanism is for normal ones.
diff --git a/src/main/java/org/scijava/module/ModuleRunner.java b/src/main/java/org/scijava/module/ModuleRunner.java
@@ -201,10 +201,7 @@ private void cleanupAndBroadcastException(final String title,
 		final Throwable t)
 	{
 		if (es != null) es.publish(new ModuleErroredEvent(module, t));
-		if (ss != null) {
-			ss.showStatus("Command errored: " + title);
-			if (t != null) ss.warn(t.getMessage());
-		}
+		if (log != null) log.error("Command errored: " + title, t);
 	}
 
 	private boolean isCanceled() {

Original file line number	Diff line number	Diff line change
`@@ -201,10 +201,7 @@ private void cleanupAndBroadcastException(final String title,`
`201`	`201`	`final Throwable t)`
`202`	`202`	`{`
`203`	`203`	`if (es != null) es.publish(new ModuleErroredEvent(module, t));`
`204`		`- if (ss != null) {`
`205`		`- ss.showStatus("Command errored: " + title);`
`206`		`- if (t != null) ss.warn(t.getMessage());`
`207`		`- }`
	`204`	`+ if (log != null) log.error("Command errored: " + title, t);`
`208`	`205`	`}`
`209`	`206`
`210`	`207`	`private boolean isCanceled() {`