Allow filtering instances before they become singletons #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DefaultSingletonService used to instantiate all the plugins matching the given type, but one might want to narrow down what becomes a singleton even further, e.g. when ImageJ2 is looking for the current platform: it wants to instantiate all plugins implementing the Platform class, but then only keep the one that claims that it matches the current platform. Therefore, let's introduce the filterInstances(List<PT>) method that returns the unmodified list of instances by default, but can be overridden in subclasses. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Dec 14, 2013
Allow filtering instances before they become singletons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DefaultSingletonService used to instantiate all the plugins matching
the given type, but one might want to narrow down what becomes a
singleton even further, e.g. when ImageJ2 is looking for the current
platform: it wants to instantiate all plugins implementing the Platform
class, but then only keep the one that claims that it matches the
current platform.
Therefore, let's introduce the filterInstances(List) method that
returns the unmodified list of instances by default, but can be
overridden in subclasses.
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de