Use List instead of Iterable as returntype of ModuleInfo methods. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returning list of ModuleItems. ``inputs()`` and ``outputs()`` used to return Iterable<ModuleItem<?>> this made random access on a Module's in and outputs painful. This restriction is not needed as the implementations of ModuleInfo already return a List.
ctrueden
added a commit
that referenced
this pull request
Jan 18, 2016
Use List instead of Iterable as returntype of ModuleInfo methods.
|
Thanks, this is long (looooooong) overdue! 😹 |
|
Reverted in edfc7c5 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that return a list of ModuleItems.
inputs()andoutputs()used to returnIterable<ModuleItem<?>>this made random access on a Module's inputs and outputs painful. This restriction is not needed as the implementations of ModuleInfo already return a List. This change breaks compatibility with custom implementations ofModuleInfo, but not with any calls to the changed methods, asListis stillIterable.