Skip to content

Use List instead of Iterable as returntype of ModuleInfo methods. #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Use List instead of Iterable as returntype of ModuleInfo methods. #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/scijava/command/CommandInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,13 @@ public <T> CommandModuleItem<T> getOutput(final String name,
}

@Override
public Iterable<ModuleItem<?>> inputs() {
public List<ModuleItem<?>> inputs() {
parseParams();
return Collections.unmodifiableList(inputList);
}

@Override
public Iterable<ModuleItem<?>> outputs() {
public List<ModuleItem<?>> outputs() {
parseParams();
return Collections.unmodifiableList(outputList);
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/scijava/module/AbstractModuleInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ public <T> ModuleItem<T> getOutput(final String name, final Class<T> type) {
}

@Override
public Iterable<ModuleItem<?>> inputs() {
public List<ModuleItem<?>> inputs() {
return Collections.unmodifiableList(inputList());
}

@Override
public Iterable<ModuleItem<?>> outputs() {
public List<ModuleItem<?>> outputs() {
return Collections.unmodifiableList(outputList());
}

Expand Down
6 changes: 4 additions & 2 deletions src/main/java/org/scijava/module/ModuleInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@

package org.scijava.module;

import java.util.List;

import org.scijava.UIDetails;
import org.scijava.Validated;
import org.scijava.event.EventService;
Expand Down Expand Up @@ -74,10 +76,10 @@ public interface ModuleInfo extends UIDetails, Validated {
<T> ModuleItem<T> getOutput(String name, Class<T> type);

/** Gets the list of input items. */
Iterable<ModuleItem<?>> inputs();
List<ModuleItem<?>> inputs();

/** Gets the list of output items. */
Iterable<ModuleItem<?>> outputs();
List<ModuleItem<?>> outputs();

/**
* Gets the fully qualified name of the class containing the module's actual
Expand Down