Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad commit in codecov #888

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

AlexVCaron
Copy link
Contributor

Quick description

When Jenkins checkouts a PR, it merges its head with the origin/master branch locally and produces a new commit. This has a bad side-effect that Jenkins knows about the revision, but no one else. Codecov reports the bad commit, but since it does not exist on Github, it can break the links between coverage reports.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Provide data, screenshots, command line to test (if relevant)

We'll see on codecov if the right commit is used and if bindings with Jenkins does work with the forced commit SHA

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AlexVCaron AlexVCaron changed the title Fix bad commit in codecov [WIP] Fix bad commit in codecov Jan 26, 2024
@arnaudbore arnaudbore self-requested a review January 26, 2024 17:23
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29c7968) 65.76% compared to head (13b8128) 65.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   65.76%   65.77%           
=======================================
  Files         384      384           
  Lines       21340    21340           
  Branches     3493     3493           
=======================================
+ Hits        14035    14037    +2     
+ Misses       5700     5699    -1     
+ Partials     1605     1604    -1     
Components Coverage Δ
Scripts 67.39% <ø> (+0.01%) ⬆️
Library 62.84% <ø> (ø)

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore changed the title [WIP] Fix bad commit in codecov Fix bad commit in codecov Jan 29, 2024
@arnaudbore arnaudbore merged commit 21ee7e4 into scilus:master Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants