-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad commit in codecov #888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build passed ! Good Job 🍻 ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #888 +/- ##
=======================================
Coverage 65.76% 65.77%
=======================================
Files 384 384
Lines 21340 21340
Branches 3493 3493
=======================================
+ Hits 14035 14037 +2
+ Misses 5700 5699 -1
+ Partials 1605 1604 -1
|
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
When Jenkins checkouts a PR, it merges its head with the origin/master branch locally and produces a new commit. This has a bad side-effect that Jenkins knows about the revision, but no one else. Codecov reports the bad commit, but since it does not exist on Github, it can break the links between coverage reports.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
We'll see on codecov if the right commit is used and if bindings with Jenkins does work with the forced commit SHA
Checklist