Add dataexplorer tests #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrussimon
force-pushed
the
dataexplorer-tests
branch
from
3464545 to
e6e19c3
Compare
ambrussimon
force-pushed
the
dataexplorer-tests
branch
from
a087e18 to
7a3dfb1
Compare
nagem
reviewed
Jul 18, 2017
api/handlers/dataexplorerhandler.py
Outdated
| } | ||
| } | ||
| if not filters: | ||
| # NOTE unreachable |
There was a problem hiding this comment.
The code will need to get updated to support device behavior for completeness. That's where an empty filter could come from (no uid for device auth), but it doesn't currently support it. I'll open a ticket about supporting device requests in search.
nagem
reviewed
Jul 18, 2017
api/handlers/dataexplorerhandler.py
Outdated
| field_query = str(field_query) | ||
| except ValueError: | ||
| # NOTE unreachable | ||
| self.abort(400, 'Must specify string for field query') |
There was a problem hiding this comment.
Do you mean the whole except or just the comment? :)
There was a problem hiding this comment.
I meant the try/except around the str cast.
nagem
reviewed
Jul 18, 2017
| } | ||
|
|
||
|
|
||
| SOURCE_COMMON = [ |
There was a problem hiding this comment.
Thanks for cleaning this up 👍
nagem
approved these changes
Jul 18, 2017
hkethi002
approved these changes
Jul 19, 2017
|
@ambrussimon-invenshure feel free to merge this one. |
ambrussimon
force-pushed
the
dataexplorer-tests
branch
from
7a3dfb1 to
bd67b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dataexplorerhandler unit test with mocked ElasticSearch.
@nagem @hkethi002:
#NOTE unreachable)Review Checklist