Coverage low hanging - final #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagem
reviewed
Jul 18, 2017
| c_metadata = self.metadata.get(self.container_type, {}) | ||
| if self.context.get('job_id') and c_metadata and not c_metadata.get('files', []): | ||
| c_metadata = self.metadata.get(self.container_type, {}) # pragma: no cover | ||
| if self.context.get('job_id') and c_metadata and not c_metadata.get('files', []): # pragma: no cover |
There was a problem hiding this comment.
Unfortunately we are still waiting on the classifier update I believe, as it was updated to use the classification tag.
nagem
reviewed
Jul 18, 2017
| # Start coverage before local module loading so their def and imports are counted | ||
| # http://coverage.readthedocs.io/en/coverage-4.2/faq.html | ||
| if os.environ.get("SCITRAN_RUNTIME_COVERAGE") == "true": | ||
| if os.environ.get("SCITRAN_RUNTIME_COVERAGE") == "true": # pragma: no cover - oh, the irony |
kofalt
reviewed
Jul 24, 2017
| if x['node_type'] == "file" and x.get('name') == criterion: | ||
| return x, FileNode | ||
| raise Exception('No ' + criterion + ' acquisition or file found.') | ||
| raise Exception('No ' + criterion + ' file found.') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #727 - declaring leftover coverage non-low-hanging
Closes #702 - perm handling got largely covered without explicit focus on the separate issue
Leftovers
Going forward - enforcement, CI integration
Ryan suggested adding no-cover to missed statements. My only addition is to add an extra tag to enable revisiting these in the future - eg.
#pragma no-cover 100%Pros:
Con:
I've also considered the incremental approach (comparing to previous commit, or to master), but found way more cons:
The current coverage-miss, sorted by missed-lines-per-file (skipping completely covered ones):
api/dao/hierarchy.pyapi/dao/containerstorage.pyapi/handlers/listhandler.pyapi/handlers/containerhandler.pyapi/handlers/reporthandler.pyapi/jobs/gears.pyapi/auth/listauth.pyapi/handlers/collectionshandler.pyapi/jobs/queue.pyapi/placer.pyapi/dao/base.pyapi/dao/containerutil.pyapi/handlers/userhandler.pyapi/web/base.pyapi/jobs/rules.pyapi/auth/containerauth.pyapi/jobs/batch.pyapi/handlers/refererhandler.pyapi/tempdir.pyapi/upload.pyapi/handlers/dataexplorerhandler.pyapi/auth/groupauth.pyapi/config.pyapi/handlers/grouphandler.pyapi/auth/userauth.pyapi/dao/liststorage.pyapi/download.pyapi/web/start.pyapi/jobs/jobs.pyapi/validators.pyapi/dao/consistencychecker.pyapi/auth/authproviders.pyapi/dao/dbutil.pyapi/jobs/handlers.pyapi/util.pyapi/auth/__init__.pyapi/dao/__init__.pyapi/files.pyapi/handlers/devicehandler.pyapi/web/encoder.pyReview Checklist