Skip to content

Code is sent with subject and test doesn't filter out acquisition files #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2017
Merged

Code is sent with subject and test doesn't filter out acquisition files #926

merged 1 commit into from
Sep 11, 2017

Conversation

hkethi002
Copy link
Contributor

Changes

  • Subject code is sent with subject to _path_from_container
  • Download filter was filtering out the acquisition files (expected) so part of the filter was removed

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem September 11, 2017 17:15
nagem
nagem reviewed Sep 11, 2017
View reviewed changes
test/integration_tests/python/test_download.py Outdated
# Verify a single file in tar with correct file name
found_second_session = False
for tarinfo in tar:
print tarinfo.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to take this out, but looks good!

@codecov-io
Copy link

codecov-io commented Sep 11, 2017 •
edited
Loading

Codecov Report

Merging #926 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files          48       48              
  Lines        6403     6407       +4     
==========================================
+ Hits         5778     5781       +3     
- Misses        625      626       +1
Flag Coverage Δ
#python 90.22% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
api/download.py 95.6% <100%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d96321...4a6142f. Read the comment docs.

@nagem
Copy link
Contributor

nagem commented Sep 11, 2017

LGTM!

@hkethi002 hkethi002 merged commit 908088c into master Sep 11, 2017
@hkethi002 hkethi002 deleted the download-subject branch September 11, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nagem nagem nagem left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkethi002 @codecov-io @nagem