Skip to content

Conversation

hkethi002
Copy link
Contributor

Fixes #882

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem September 27, 2017 14:35
@codecov-io
Copy link

Codecov Report

Merging #943 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #943      +/-   ##
=========================================
+ Coverage   90.19%   90.2%   +<.01%     
=========================================
  Files          48      48              
  Lines        6418    6421       +3     
=========================================
+ Hits         5789    5792       +3     
  Misses        629     629
Flag Coverage Δ
#python 90.2% <100%> (ø) ⬆️
Impacted Files Coverage Δ
api/handlers/confighandler.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124ea0c...cee4e59. Read the comment docs.

@nagem
Copy link
Contributor

nagem commented Sep 29, 2017

LGTM!

@hkethi002 hkethi002 merged commit 766c29a into master Sep 29, 2017
@hkethi002 hkethi002 deleted the missing-version branch September 29, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants