Skip to content

Version returns 404 if version doc is missing #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Version returns 404 if version doc is missing #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion api/handlers/confighandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,8 @@ class Version(base.RequestHandler):

def get(self):
"""Return database schema version"""
return config.get_version()
resp = config.get_version()
if resp != None:
return resp
else:
self.abort(404, "Version document does not exist")
10 changes: 8 additions & 2 deletions test/integration_tests/python/test_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,14 @@ def test_devicehandler(as_user, as_root, as_drone, api_db):
api_db.devices.remove({'_id': 'test_drone'})


def test_config_version(as_user):
def test_config_version(as_user, api_db):
# get database version when no version document exists, It hasn;t been set yet in the tests
r = as_user.get('/version')
assert r.status_code == 404
api_db.singletons.insert_one({"_id":"version","database":3})

# get database schema version
r = as_user.get('/version')
assert r.ok
assert r.text == '' # not set yet
assert r.json()['database'] == 3
api_db.singletons.find_one_and_delete({'_id':'version'})