Skip to content

Conversation

Gallaecio
Copy link
Member

No description provided.

@Gallaecio Gallaecio force-pushed the changes-new-version branch 2 times, most recently from 244fd53 to c6ed830 Compare August 1, 2019 16:32
@Gallaecio Gallaecio changed the title Cover Parsel 1.1.0 in the CHANGES file Cover cssselect 1.1.0 in the CHANGES file Aug 1, 2019
@kmike
Copy link
Member

kmike commented Aug 8, 2019

We may need CI fix as well before the release.

@Gallaecio Gallaecio changed the title Cover cssselect 1.1.0 in the CHANGES file [WIP] Cover cssselect 1.1.0 in the CHANGES file Aug 9, 2019
@Gallaecio Gallaecio force-pushed the changes-new-version branch from c6ed830 to 20ae2ac Compare August 9, 2019 08:42
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   95.49%   95.16%   -0.33%     
==========================================
  Files           2        2              
  Lines         754      703      -51     
  Branches      128      116      -12     
==========================================
- Hits          720      669      -51     
  Misses         19       19              
  Partials       15       15
Impacted Files Coverage Δ
cssselect/parser.py 95.37% <0%> (-0.5%) ⬇️
cssselect/xpath.py 94.86% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5c7a8...20ae2ac. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   95.49%   95.16%   -0.33%     
==========================================
  Files           2        2              
  Lines         754      703      -51     
  Branches      128      116      -12     
==========================================
- Hits          720      669      -51     
  Misses         19       19              
  Partials       15       15
Impacted Files Coverage Δ
cssselect/parser.py 95.37% <0%> (-0.5%) ⬇️
cssselect/xpath.py 94.86% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5c7a8...20ae2ac. Read the comment docs.

@Gallaecio Gallaecio force-pushed the changes-new-version branch from 20ae2ac to cff38f1 Compare August 9, 2019 09:11
@Gallaecio Gallaecio changed the title [WIP] Cover cssselect 1.1.0 in the CHANGES file Cover cssselect 1.1.0 in the CHANGES file Aug 9, 2019
@Gallaecio Gallaecio merged commit fffc0b6 into scrapy:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants