Skip to content

Conversation

akshita27
Copy link

Ran the tests from test directory with python 3.7.4

This references #91

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files           2        2           
  Lines         754      754           
  Branches      128      128           
=======================================
  Hits          720      720           
  Misses         19       19           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518e3e1...24eb095. Read the comment docs.

@kmike
Copy link
Member

kmike commented Oct 16, 2019

Thanks @akshita27! Do you think you can add py37 to tox.ini and travis.yml, to make sure we run Python 3.7 tests on CI? I think we can only declare support after it is enabled on CI.

@akshita27
Copy link
Author

Hi @kmike, I have added py37 in tox.ini and travis.yml. Please review the changes.

@kmike kmike merged commit eb40f21 into scrapy:master Oct 16, 2019
@kmike
Copy link
Member

kmike commented Oct 16, 2019

Awesome, thanks @akshita27!

@Gallaecio Gallaecio mentioned this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants