Write the 1.7 release notes #3846

Gallaecio · 2019-06-27T13:59:56Z

Current coverage: 44eb21a

Includes a note about dropping Python 2 support in Scrapy 2.0.

codecov · 2019-06-27T14:23:01Z

Codecov Report

Merging #3846 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3846   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         164      164           
  Lines        9565     9565           
  Branches     1435     1435           
=======================================
  Hits         8184     8184           
  Misses       1133     1133           
  Partials      248      248

kmike · 2019-06-28T13:32:38Z

hey @Gallaecio! I also tried to put all pull requests for new changes in thee 1.7 milestone a few days ago (https://github.com/scrapy/scrapy/milestone/22), maybe this would help you. Not 100% sure all PRs are there though, I could have missed something, or added something which shouldn't be there.

docs/news.rst

Gallaecio · 2019-07-01T11:33:29Z

hey @Gallaecio! I also tried to put all pull requests for new changes in thee 1.7 milestone a few days ago (https://github.com/scrapy/scrapy/milestone/22), maybe this would help you. Not 100% sure all PRs are there though, I could have missed something, or added something which shouldn't be there.

Thanks! I’ll complete the release notes based on commits just to make sure I don’t miss anything, and then compare the result to the milestone to ensure that everything fits.

Gallaecio · 2019-07-01T13:19:57Z

readthedocs/sphinx_rtd_theme#705 is making some list items look rather badly, I hope they fix it soon.

Gallaecio · 2019-07-01T18:23:49Z

Current coverage:

Commits until 3adf09b
Pending pull requests [MRG+1] Fix form methods in FormRequest.from_response (#3777) #3794 and Deprecation removals for Scrapy 1.7 #3578

While I’m confident about the coverage (as in I don’t think any issue is missing), I’m more than grateful for any feedback regarding everything else (e.g. content organization, header naming).

docs/news.rst

Gallaecio · 2019-07-02T15:41:24Z

Moved those 3 new features to the top, simplified the list of deprecations further to remove as much visual clutter as possible without loss of information, and covered #3692.

Current coverage: 4c755f1 + #3578

Gallaecio · 2019-07-04T17:20:30Z

Added a note about Scrapy 2.0 dropping support for Python 2.

Gallaecio · 2019-07-04T17:57:25Z

I’ll keep the description up-to-date with the release notes coverage.

elacuesta · 2019-07-09T19:49:58Z

Hi there @Gallaecio, @kmike, have we reached feature freeze for 1.7 or is there a chance to include #3712 and #2400? Thanks!

docs/news.rst

Gallaecio · 2019-07-11T05:11:12Z

Both suggestions applied.

I’ve also made some changes to the documentation from #3829 which include fixes for link syntax issues that I overlooked.

kmike · 2019-07-11T07:13:09Z

docs/news.rst

+~~~~~~~~~~~~~
+
+*   ``scrapy.utils.gz.is_gzipped`` is now **deprecated**. Use
+    ``scrapy.utils.gz.gzip_magic_number`` instead.


should it be moved to Deprecations section?

Right! 🤦‍♂️

Done.

I’ve also moved the two deprecation comments from New features to Deprecations as well.

kmike · 2019-07-11T08:42:09Z

docs/news.rst

+
+*   The ``queuelib.PriorityQueue`` value for the
+    :setting:`SCHEDULER_PRIORITY_QUEUE` setting is deprecated. Use
+    :class:`scrapy.pqueues.ScrapyPriorityQueue` instead.


This is actually backwards incompatible: only exact queuelib.PriorityQueue class still works, its custom subclasses don't. See

scrapy/scrapy/core/scheduler.py

Line 59 in df68c4b

if pqclass is PriorityQueue:

The main API change is that priority queue class now needs to support Request objects, not just general Python data structures; compare

scrapy/scrapy/pqueues.py

Line 93 in df68c4b

class ScrapyPriorityQueue(PriorityQueue):

and https://github.com/scrapy/queuelib/blob/master/queuelib/pqueue.py.

I'm not sure how detailed should be our deprecation docs on this, as this API was not documented before, if I'm not mistaken.

I’ve added a short entry to the backward incompatibility section, please have a look and share your thoughts.

elacuesta · 2019-07-12T15:51:01Z

Added a note about Scrapy 2.0 dropping support for Python 2.

Can't wait for this. Don't get me wrong, I think six does an awesome job, but it'll be good to clean up the codebase.

Gallaecio · 2019-07-16T10:41:44Z

Updated to fix #3872.

Gallaecio · 2019-07-18T08:39:46Z

As part of the last updated, I’ve:

Installed the InterSphinx extension to easily link to external documentations also built using Sphinx, like Python’s. ChainMap served as an excuse for it 🙂
Grouped together a few of the documentation entries, to make the documentation section shorter.
Moved the entry about generating documentation coverage data to Other changes, as it’s meant for contributors, not users.

…e upcoming 2.0

kmike added this to the v1.7 milestone Jun 28, 2019

Gallaecio commented Jul 1, 2019

View reviewed changes

docs/news.rst Outdated Show resolved Hide resolved

docs/news.rst Outdated Show resolved Hide resolved

Gallaecio force-pushed the release-notes-1.7 branch from c012b4a to 010eab9 Compare July 1, 2019 18:18

Gallaecio marked this pull request as ready for review July 1, 2019 18:23

kmike reviewed Jul 2, 2019

View reviewed changes

docs/news.rst Outdated Show resolved Hide resolved

Gallaecio force-pushed the release-notes-1.7 branch 2 times, most recently from 06ee14a to 54a56a9 Compare July 2, 2019 15:38

Gallaecio force-pushed the release-notes-1.7 branch from 54a56a9 to 561956f Compare July 4, 2019 17:18

Gallaecio force-pushed the release-notes-1.7 branch from 561956f to 8cc0664 Compare July 4, 2019 17:56

Gallaecio force-pushed the release-notes-1.7 branch 4 times, most recently from c8a8b40 to fa44545 Compare July 9, 2019 08:14

Gallaecio mentioned this pull request Jul 9, 2019

[ON HOLD] Provide a single page that covers all backward-incompatible changes and deprecations #3636

Open

Gallaecio force-pushed the release-notes-1.7 branch from fa44545 to fa21f6c Compare July 10, 2019 09:31

elacuesta reviewed Jul 10, 2019

View reviewed changes

docs/news.rst Outdated Show resolved Hide resolved

kmike reviewed Jul 10, 2019

View reviewed changes

docs/news.rst Outdated Show resolved Hide resolved

Gallaecio force-pushed the release-notes-1.7 branch from fa21f6c to a5790b0 Compare July 11, 2019 05:09

kmike reviewed Jul 11, 2019

View reviewed changes

Gallaecio force-pushed the release-notes-1.7 branch from a5790b0 to 015ea0c Compare July 11, 2019 07:35

Gallaecio force-pushed the release-notes-1.7 branch 2 times, most recently from 5b238fd to cd1a74f Compare July 11, 2019 07:40

kmike reviewed Jul 11, 2019

View reviewed changes

Gallaecio force-pushed the release-notes-1.7 branch 2 times, most recently from 76035f4 to d17f800 Compare July 11, 2019 10:09

Gallaecio force-pushed the release-notes-1.7 branch 4 times, most recently from 3cd41c3 to fa9f13e Compare July 15, 2019 10:49

elacuesta mentioned this pull request Jul 15, 2019

Prevent deprecation warnings #3877

Merged

Gallaecio force-pushed the release-notes-1.7 branch from fa9f13e to e9f0850 Compare July 16, 2019 10:40

Gallaecio force-pushed the release-notes-1.7 branch from e9f0850 to 47f2c8b Compare July 17, 2019 07:48

Gallaecio force-pushed the release-notes-1.7 branch 2 times, most recently from 12654fa to 8624c9f Compare July 18, 2019 13:33

Write the 1.7 release notes and cover dropping Python 2 support in th…

8c84294

…e upcoming 2.0

Gallaecio force-pushed the release-notes-1.7 branch from 8624c9f to 8c84294 Compare July 18, 2019 13:36

Gallaecio merged commit a94b5be into scrapy:master Jul 18, 2019

Gallaecio deleted the release-notes-1.7 branch June 14, 2020 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write the 1.7 release notes #3846

Write the 1.7 release notes #3846

Gallaecio commented Jun 27, 2019 •

edited

Loading

codecov bot commented Jun 27, 2019 •

edited

Loading

kmike commented Jun 28, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 2, 2019

Gallaecio commented Jul 4, 2019

Gallaecio commented Jul 4, 2019

elacuesta commented Jul 9, 2019

Gallaecio commented Jul 11, 2019

kmike Jul 11, 2019

Gallaecio Jul 11, 2019

Gallaecio Jul 11, 2019

kmike Jul 11, 2019

Gallaecio Jul 11, 2019

elacuesta commented Jul 12, 2019

Gallaecio commented Jul 16, 2019

Gallaecio commented Jul 18, 2019

Write the 1.7 release notes #3846

Write the 1.7 release notes #3846

Conversation

Gallaecio commented Jun 27, 2019 • edited Loading

codecov bot commented Jun 27, 2019 • edited Loading

Codecov Report

kmike commented Jun 28, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 1, 2019

Gallaecio commented Jul 2, 2019

Gallaecio commented Jul 4, 2019

Gallaecio commented Jul 4, 2019

elacuesta commented Jul 9, 2019

Gallaecio commented Jul 11, 2019

kmike Jul 11, 2019

Choose a reason for hiding this comment

Gallaecio Jul 11, 2019

Choose a reason for hiding this comment

Gallaecio Jul 11, 2019

Choose a reason for hiding this comment

kmike Jul 11, 2019

Choose a reason for hiding this comment

Gallaecio Jul 11, 2019

Choose a reason for hiding this comment

elacuesta commented Jul 12, 2019

Gallaecio commented Jul 16, 2019

Gallaecio commented Jul 18, 2019

Gallaecio commented Jun 27, 2019 •

edited

Loading

codecov bot commented Jun 27, 2019 •

edited

Loading