-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Migrate CI to GitHub actions #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
- Coverage 95.45% 91.94% -3.52%
==========================================
Files 7 7
Lines 484 484
Branches 99 99
==========================================
- Hits 462 445 -17
- Misses 15 22 +7
- Partials 7 17 +10
|
@pytest.mark.xfail(reason="https://github.com/scrapy/w3lib/issues/164") | ||
def test_add_or_replace_parameter_fail(self): | ||
self.assertEqual( | ||
add_or_replace_parameter('http://domain/test?arg1=v1;arg2=v2', 'arg1', 'v3'), | ||
'http://domain/test?arg1=v3&arg2=v2' | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a temporary workaround to avoid having the workflows fail (#164)
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-20.04 | ||
strategy: | ||
matrix: | ||
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change mean in practice (some versions are dropped)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions in this file are indicated along job definitions under include
.
But these versions have actually been moved to the new tests.yml
file. This file is now only for static tests (maybe Build
is not the best name, Check
as we use in Scrapy is slightly better).
Based on Scrapy's config.
This will need a
PYPI_TOKEN
repository secret to be set. Publishing to PyPI is working against the testing instance (see https://test.pypi.org/project/w3lib/, pushed from https://github.com/elacuesta/w3lib/runs/2078491608)