Skip to content

Commit 9a9c9d5

Browse files
fix: add more logs
1 parent c8985fd commit 9a9c9d5

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

lambda_function.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,12 @@ def lambda_handler(event: {}, context: {})
7575
metricname: ENV.fetch('METRICNAME', 'elasticache.slowlog')
7676
)
7777

78-
@slowlog_check.update_metadatas
78+
if ENV.fetch('SKIP_METADATA_UPDATE', 'false').casecmp('true').zero?
79+
LOGGER.warn 'Skipping Datadog metadata update due to SKIP_METADATA_UPDATE=true'
80+
else
81+
LOGGER.info 'Updating Datadog metric metadata'
82+
@slowlog_check.update_metadatas
83+
end
7984
end
8085

8186
@slowlog_check.ship_slowlogs

lib/slowlog_check.rb

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,13 @@ def get_metadatas
319319
count
320320
].map do |metric|
321321
name = @metricname + '.' + metric
322+
LOGGER.debug "Fetching metadata for #{name}"
322323
@ddog.get_metadata(name)[1]
323324
.merge('name' => name)
324325
end
326+
rescue StandardError => e
327+
LOGGER.warn "Unable to fetch metric metadata: #{e.class} #{e.message}"
328+
[]
325329
end
326330

327331
def diff_metadatas
@@ -331,11 +335,16 @@ def diff_metadatas
331335
def update_metadatas
332336
diff_metadatas.each do |metadata|
333337
name = metadata.delete('name')
334-
resp = @ddog.update_metadata(
335-
name,
336-
metadata.transform_keys(&:to_sym)
337-
)
338-
LOGGER.info "Updating metadata for #{name} #{status_or_error(resp)}"
338+
LOGGER.info "Updating metadata for #{name}"
339+
begin
340+
resp = @ddog.update_metadata(
341+
name,
342+
metadata.transform_keys(&:to_sym)
343+
)
344+
LOGGER.info "Updating metadata for #{name} #{status_or_error(resp)}"
345+
rescue StandardError => e
346+
LOGGER.error "Failed to update metadata for #{name}: #{e.class} #{e.message}"
347+
end
339348
end
340349
end
341350
end

0 commit comments

Comments
 (0)