[SERF-3423] Adding MySQL driver instrumentation

[laynax]

Description

This PR adds MySQL driver tracing using dd-trace-go library.

Testing considerations

Tested on document-search staging.

Sample span:

Checklist

• Prefixed the PR title with the JIRA ticket code
• Performed simple, atomic commits with [good commit messages][commit messages]
• Verified that the commit history is linear and commits are squashed as necessary
• Thoroughly tested the changes in development and/or staging
• Updated the README.md as necessary

Related links

• SERF-3423
• https://github.com/DataDog/dd-trace-go/blob/main/contrib/gorm.io/gorm.v1/gorm_test.go

[fotos]

👍 LGTM 🚀

[fotos]

I think those need to be the other way around? 🤔

The (MySQL) driver is %s-mysql and the db (ORM) is %s-orm.

Suggested change

	dbServiceName := fmt.Sprintf("%s-mysql", appName)
	driverServiceName := fmt.Sprintf("%s-orm", appName)
	dbServiceName := fmt.Sprintf("%s-orm", appName)
	driverServiceName := fmt.Sprintf("%s-mysql", appName)

[laynax]

Current value for dbServiceName is with -mysql, this way we will have document-search-orm instead.
Maybe change driverServiceName to appname-dbdriver?

[Neurostep]

I agree with @fotos about the naming: the -orm should be assigned to the gorm instrumentation, and the -mysql to the MySQL driver instrumentation.

@laynax If we change the name for the gORM instrumentation, what happens? I think the only thing will change is the DataDog metric names, which we will need to update anyway

[laynax]

@fotos @Neurostep

Changed as requested 👍

Overall I'm against having more than one service name for each service, it must be the operation name providing info about orm or mysql type.

[Neurostep]

@fotos A brief update here. After discussing this PR with @laynax we decided to keep the service name as is %s-mysql (document-search-mysql) as it will make things easier and effectively a part of one database flow. One can distinguish between different span types using the operation type drop-down (see screenshot). Please, let us know what you think about this 🙏

@laynax Let's update the service name here using -mysql suffix for both clients 👍

[fotos]

Sounds good to me!

Let's see how that works in practice. 👍

[fotos]

👍 LGTM 🚀

[Neurostep]

LGTM 🚀