[SERF-3424] Fix DB connection initialization for test environment #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the Go Chassis and Go SDK upgrades in the
document-search
service, we noticed a broken behavior of thedatabase.NewConnection
function when called in thetest
environment: the following error was raisedThe issue is due to the fact that we started using
sqltrace
from thedd-trace-go
library to register the driver and initialize the DB connection, but thetest
-related initialization was still relying on thesql
interface from thedatabase/sql
package.In this PR we upgraded the
go-txdb
to the latestv0.1.9
version and usedsqltrace
for all environments.Testing considerations
development
and/orstaging
environment and check if all works as expectedChecklist
development
and/orstaging
Updated theREADME.md
as necessaryRelated links