Skip to content

Conversation

@marcelolebre
Copy link

I'm currently working on a project that requires google auth to be domain sensitive.

I decided to extend this implementation to support the hd param that allows this.

@coveralls
Copy link

coveralls commented Oct 6, 2017

Coverage Status

Coverage increased (+0.06%) to 94.527% when pulling c1fa87d on marcelolebre:hosted_domain into 246897a on scrogson:master.

@marcelolebre marcelolebre changed the title Hosted domain Hosted domain Support Oct 6, 2017
@scrogson
Copy link
Member

scrogson commented Oct 6, 2017

Hi there @marcelolebre,

Thank you for your interest in contributing to this library. After reviewing your pull request, it appears that the feature you are adding is not apart of the OAuth2 specification and does not pertain to all providers.

This library aims to only provide the building blocks for building OAuth2 clients. The strategies are defined as they are outlined in the OAuth2 spec and are meant to be built on top of.

What you seek can be achieved very easily with OAuth2.Client.put_param/3. Or by simply passing in the :hd option into your Google.authorize_url!(client, hd: "example.com") example.

@scrogson scrogson closed this Oct 6, 2017
@marcelolebre
Copy link
Author

hi @scrogson,

Thanks for the feedback. It felt weird to hardcode it as it's so widely used.

But I guess it makes sense to keep it true to the specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants