perf: skipping computing compression ratio for l1 messages #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
reviewed
Sep 26, 2025
| // Note: We compute the transaction ratio on tx.data, not on the full encoded transaction. | ||
| let compression_ratio = compute_compression_ratio(base.input()); | ||
| Self::new(base, encoded, Some(compression_ratio)) | ||
| let compression_ratio = |
There was a problem hiding this comment.
then_some is eagerly evaluated. Better to use then to avoid the computation altogether for L1 messages. (Or just a simple if expression.)
There was a problem hiding this comment.
encoded is ok, since it's just a reference to a var, it's fine to evaluate it eagerly.
greged93
reviewed
Sep 26, 2025
| // Note: We compute the transaction ratio on tx.data, not on the full encoded transaction. | ||
| let compression_ratio = compute_compression_ratio(base.input()); | ||
| Self::new(base, encoded, Some(compression_ratio)) | ||
| let compression_ratio = (!tx.is_l1_message()).then(compute_compression_ratio(base.input())); |
There was a problem hiding this comment.
then takes a FnOnce, you need to add ||
| // Note: We compute the transaction ratio on tx.data, not on the full encoded transaction. | ||
| let compression_ratio = compute_compression_ratio(base.input()); | ||
| Self::new(base, encoded, Some(compression_ratio)) | ||
| let compression_ratio = (!tx.is_l1_message()).then(compute_compression_ratio(base.input())); |
CodSpeed Performance ReportMerging #345 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Issue #344, Computing compression ratio is skipped for L1 messages.