Skip to content

perf: skipping computing compression ratio for l1 messages #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
+7 −4
Merged

perf: skipping computing compression ratio for l1 messages #345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a78eaa
perf: skipping computing compression ratio for l1 messages
Parizval Sep 25, 2025
44344b9
refactor: updating compression_ratio expression to lazy evaluation
Parizval Sep 26, 2025
337c392
fix: refactored closure function for compute_compression_ratio
Parizval Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/scroll/alloy/evm/src/tx/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,9 @@ impl FromTxWithEncoded<ScrollTxEnvelope> for ScrollTransactionIntoTxEnv<TxEnv> {

let encoded = (!tx.is_l1_message()).then_some(encoded);
// Note: We compute the transaction ratio on tx.data, not on the full encoded transaction.
let compression_ratio = compute_compression_ratio(base.input());
Self::new(base, encoded, Some(compression_ratio))
let compression_ratio =
(!tx.is_l1_message()).then(|| compute_compression_ratio(base.input()));
Self::new(base, encoded, compression_ratio)
}
}

Expand Down Expand Up @@ -270,7 +271,9 @@ impl FromRecoveredTx<ScrollTxEnvelope> for ScrollTransactionIntoTxEnv<TxEnv> {

let encoded = (!tx.is_l1_message()).then_some(envelope.into());
// Note: We compute the transaction ratio on tx.data, not on the full encoded transaction.
let compression_ratio = compute_compression_ratio(base.input());
Self::new(base, encoded, Some(compression_ratio))
let compression_ratio =
(!tx.is_l1_message()).then(|| compute_compression_ratio(base.input()));

Self::new(base, encoded, compression_ratio)
}
}
Loading