fix(rollup-relayer): rollup status overwrite

[colinlyguo]

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change

Summary by CodeRabbit

• Chores

  • Updated the software version to v4.4.99.

• Bug Fixes

  • Enhanced the update process for batch operations by preventing modifications to entries that have been finalized, ensuring improved data consistency and stability.
  • Adjusted test assertions to reflect changes in expected outcomes regarding rollup statuses and the number of batches retrieved.

[coderabbitai]

Walkthrough

This pull request updates the software version by changing the version tag from "v4.4.98" to "v4.4.99" in the version file. It also improves the control flow in the batch update method by adding logic to retrieve the current batch status and immediately exit if the batch is already finalized. No other code logic or public interfaces are modified.

Changes

File(s)	Summary
common/.../version.go	Updated the version tag variable from "v4.4.98" to "v4.4.99".
rollup/.../batch.go	Added logic in UpdateCommitTxHashAndRollupStatus to query the current batch and return early if its RollupStatus is RollupFinalized.
rollup/.../orm_test.go	Modified assertions in TestBatchOrm to reflect changes in expected CommitTxHash and RollupStatus, and adjusted the expected number of batches retrieved.

Possibly related PRs

• fix(sender): graceful restart #1567: The changes in the main PR update the version tag in the same file as the retrieved PR, which also modifies the version tag, indicating a direct relationship between the two.
• fix(sender): graceful restart #1564: The changes in the main PR involve updating the version tag in the same file (common/version/version.go) as the retrieved PR, indicating a direct relationship at the code level.
• fix(rollup-relayer): check if previous bundle or batch is finalized in fake finalize mode #1563: The changes in the main PR, which update the version tag in common/version/version.go, are directly related to the changes in the retrieved PR that also modify the same tag variable in the same file, albeit to a different version number.

Suggested labels

bump-version

Suggested reviewers

• georgehao
• 0xmountaintop

Poem

I'm a little rabbit, hopping through the code,
Version tag leaps high, along the digital road.
I nibble on commits and dance with every check,
Early exits keep errors away, what the heck!
With ASCII carrots and code so neat, our project hops to a brilliant beat.
🐇🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84ca61b and 63f02ad.

📒 Files selected for processing (1)

• rollup/internal/orm/batch.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rollup/internal/orm/batch.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: tests

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.50%. Comparing base (0a1868c) to head (63f02ad).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
rollup/internal/orm/batch.go	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1638   +/-   ##
========================================
  Coverage    41.49%   41.50%           
========================================
  Files          222      222           
  Lines        18220    18228    +8     
========================================
+ Hits          7561     7566    +5     
- Misses        9926     9928    +2     
- Partials       733      734    +1     

Flag	Coverage Δ
rollup	52.07% <62.50%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.