fix(rollup-relayer): update commit status logic

[colinlyguo]

Purpose or design rationale of this PR

When the status is "finalizing" or "finalized", other info fields of the commit status should still be updated.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change

Summary by CodeRabbit

• Chores

  • Updated version number to v4.5.8.

• Bug Fixes

  • Improved the handling of rollup status updates to prevent overwriting finalizing or finalized states.
  • Adjusted commit transaction hash handling to reflect updated batch state expectations in tests.

[coderabbitai]

Walkthrough

The version tag in the codebase was updated from "v4.5.7" to "v4.5.8". Additionally, the logic for updating the rollup_status field in the database was modified to use a conditional SQL statement, ensuring certain statuses are not overwritten, and removing the previous early exit check. The related test was updated to reflect the new expected commit transaction hash.

Changes

File(s)	Change Summary
common/version/version.go	Updated the version tag string from "v4.5.7" to "v4.5.8".
rollup/internal/orm/batch.go	Modified UpdateCommitTxHashAndRollupStatus to use a SQL CASE expression for conditional status update; removed early exit logic based on current status.
rollup/internal/orm/orm_test.go	Updated test assertion to expect CommitTxHash to be "commitTxHash" instead of an empty string.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ORM
    participant Database

    Caller->>ORM: UpdateCommitTxHashAndRollupStatus(batchID, txHash, status)
    ORM->>Database: Execute SQL UPDATE with CASE on rollup_status
    Database-->>ORM: Update result
    ORM-->>Caller: Return result

Loading

Possibly related PRs

• fix(rollup-relayer): rollup status overwrite #1638: Both PRs modify the logic for updating rollup_status in UpdateCommitTxHashAndRollupStatus, but approach the conditional update differently.
• fix(sender): graceful restart #1564: Similar version tag update in common/version/version.go for a different version bump.

Suggested labels

bump-version

Suggested reviewers

• jonastheis
• georgehao

Poem

A hop from seven to eight,
The version tag updates its fate.
Rollup status now stands tall,
With SQL CASE, it won’t fall.
No more early exit dash—
Only careful, conditional hash!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f831e30 and 5ae47ec.

📒 Files selected for processing (1)

• rollup/internal/orm/orm_test.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: tests

🔇 Additional comments (1)

rollup/internal/orm/orm_test.go (1)

317-317: Test updated to verify commit hash updates are preserved in finalized batches

The test now verifies that the CommitTxHash field is correctly updated to "commitTxHash" even when the batch has already reached the RollupFinalized status. This aligns with the PR's purpose of ensuring informational fields continue to be updated even when the batch status is in a terminal state (finalizing or finalized).

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.68%. Comparing base (a18fe06) to head (5ae47ec).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1656   +/-   ##
========================================
  Coverage    40.67%   40.68%           
========================================
  Files          225      225           
  Lines        18417    18415    -2     
========================================
+ Hits          7492     7493    +1     
+ Misses       10193    10191    -2     
+ Partials       732      731    -1     

Flag	Coverage Δ
rollup	49.32% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.