refactor(coordinator): remove outdated logic #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
This change removes the legacy `EuclidVerifier` and its associated logic, consolidating verifier management to only use `EuclidV2Verifier`. All references to the old verifier are deleted, and related configuration handling is simplified. The version tag is incremented to "v4.5.18".
## Changes
| File(s) | Change Summary |
|------------------------------------------------------|------------------------------------------------------------------------------------------------|
| common/libzkp/impl/src/verifier.rs | Removed all references to `EuclidVerifier` and `VERIFIER_LOW`; simplified to only use `VERIFIER_HIGH` with `EuclidV2Verifier`. |
| common/libzkp/impl/src/verifier/euclid.rs | Deleted file; removed `EuclidVerifier` struct and its methods for proof verification and VK dumping. |
| coordinator/internal/logic/auth/login.go | Removed inclusion of `EuclidFork` and `EuclidV2Fork` in `highHardForks`; now only uses configured fork name. |
| common/version/version.go | Updated version tag from "v4.5.17" to "v4.5.18". |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant Config
participant VerifierManager
participant EuclidV2Verifier
Config->>VerifierManager: Provide fork_name
VerifierManager->>EuclidV2Verifier: Initialize with fork_name
VerifierManager->>VerifierManager: Store EuclidV2Verifier as only verifier
Note over VerifierManager: Legacy EuclidVerifier is removedPossibly related PRs
Suggested reviewers
Poem
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1668 +/- ##
===========================================
+ Coverage 40.88% 40.98% +0.10%
===========================================
Files 225 225
Lines 18072 18071 -1
===========================================
+ Hits 7388 7406 +18
+ Misses 9967 9945 -22
- Partials 717 720 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgehao
approved these changes
May 26, 2025
zimpha
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
The latest circuit version (
>= v0.3.0) is not compatible witheuclidprover/verifier anymore. This PR removes outdated logic.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
Chores
Refactor