This repository was archived by the owner on Apr 18, 2025. It is now read-only.
fix/keccak-decode-overflow: calculate with bitshifts in u64 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
force-pushed
the
fix/keccak-decode-overflow
branch
from
0b34177 to
091ab14
Compare
|
i am curious that i sometimes use k = 20 or 28, but everything works well? 20 / 28 is even bigger than 19.. |
|
That works, there is test in #326 |
|
Maybe you were using profile "bench"? Or set |
Merged
4 tasks
CPerezz
pushed a commit
to privacy-ethereum/zkevm-circuits
that referenced
this pull request
Feb 27, 2023
### Description With `KECCAK_DEGREE=19`, `get_num_bits_per_absorb_lookup()` is 11. In some places, `2**3**11` overflows `u32`. Replace with `u64`. Also use faster bitshifts like Axiom’s version. ### Issue Link Port fix from Scroll scroll-tech#335 ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - Compute in `u64` ### How Has This Been Tested? cargo test -p zkevm-circuits --features test --release -- keccak Co-authored-by: Aurélien Nicolas <info@nau.re>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
KECCAK_DEGREE=19,get_num_bits_per_absorb_lookup()is 11. In some places,2**3**11overflowsu32.Replace with
u64. Also use faster bitshifts like Axiom’s version.