This repository was archived by the owner on Apr 18, 2025. It is now read-only.
test/keccak-normalize-table: unittest for lookup tables #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
force-pushed
the
test/keccak-normalize-table
branch
from
062733a to
f47277e
Compare
naure
force-pushed
the
test/keccak-normalize-table
branch
from
f47277e to
4eee161
Compare
naure
force-pushed
the
test/keccak-normalize-table
branch
from
ab7ae1f to
1bb964c
Compare
naure
changed the title
naure
force-pushed
the
test/keccak-normalize-table
branch
from
1bb964c to
8f764f3
Compare
lispc
reviewed
Feb 20, 2023
lispc
approved these changes
Feb 20, 2023
4 tasks
ChihChengLiang
pushed a commit
to privacy-ethereum/zkevm-circuits
that referenced
this pull request
Mar 2, 2023
…les (#1263) ### Description This PR verifies the properties of the lookup tables used in Keccak. A port of scroll-tech#326 ### Issue Link This is a good regression test before #1241 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - A test circuit that populates the fixed lookup tables using the functions under test. - Check that the table contain valid values, and nothing else. - Minor refactoring for testability. Make pure functions that calculate parameters, and isolate the dependency on environment variables. ### How Has This Been Tested? cargo test -p zkevm-circuits --features test --release -- keccak --------- Co-authored-by: Aurélien Nicolas <info@nau.re>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies the properties of the lookup tables used in Keccak. Also minor refactoring for testability.