-
Notifications
You must be signed in to change notification settings - Fork 1
CuPy support #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CuPy support #51
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 96.87% 98.45% +1.58%
==========================================
Files 15 15
Lines 256 259 +3
==========================================
+ Hits 248 255 +7
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #51 will improve performances by ×2.9Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to mostly just add types and a sum function? Is the reason that this all just "works" because cupy
handles numpy
well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm getting a bit concerned about all the casting going on but since it's in pre-commit, it should be manageable from a us-reviewing-other-PRs perspective i.e., we can always just tell people to look at the output. I was a little worried that there was no CI around this
Casting? You mean mypy? I think mypy and Python’s type system are simply not that great. With TypeScript, I could rely on the type system saying the truth, but in Python it’s more often an error in the typing or a bug in mypy than my fault. Makes the whole ordeal of rather limited use tbh if one can’t rely on the type system. Maybe switching to PyRight could help. |
Fixes #3
Intended properties:
as_dense(to_memory=True)
ofc