-
Notifications
You must be signed in to change notification settings - Fork 1
Add order
parameter to to_dense
#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #94 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
===========================================
- Coverage 98.27% 83.45% -14.83%
===========================================
Files 17 17
Lines 406 417 +11
===========================================
- Hits 399 348 -51
- Misses 7 69 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a bit more info in the public API, looks good
order | ||
The order of the output array: ``C`` (row-major) or ``F`` (column-major). ``K`` and ``A`` derive the order from ``x``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add more info here i.e., what you say in the PR comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diverges from e.g. scipy’s default behavior, because
_csbase.toarray
has"C"
as default, whereas numpy has"K"
as default, and I think the behavior should be the same in both cases.Therefore CSC matrices become F-contiguous arrays when
order="K"
(the default).Dask is problematic, because it doesn’t allow to specify order at all: It basically does what it wants, so we can’t really test for sane behavior.