Skip to content

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Aug 11, 2025

index.equal also checks for the index values. They are str for obs columns from AnnData objects, while they are range indices for pandas dataframes. This PR converts the indices of the latter to str.

Note that the index is never used downstream (we use the instance_key column instead), so an alternative approach would have been to change the assert statements to have them compare the values of the columns, and not the indices.

@LucaMarconato LucaMarconato merged commit b9c3262 into main Aug 14, 2025
4 checks passed
@LucaMarconato LucaMarconato deleted the fix_index_check_xenium branch August 14, 2025 16:45
@LucaMarconato LucaMarconato changed the title more permissive check index xenium Xenium conversion of indexes to str Aug 14, 2025
@LucaMarconato
Copy link
Member Author

Also this small commit was needed: dda3ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant