Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when plotting shapes after spatial query #177

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Most likely a problem with the drop_index()

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Oct 30, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #177 (a8b60b3) into main (c1cc849) will increase coverage by 0.85%.
Report is 8 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   77.09%   77.94%   +0.85%     
==========================================
  Files          11       11              
  Lines        1196     1297     +101     
==========================================
+ Hits          922     1011      +89     
- Misses        274      286      +12     
Files Coverage Δ
src/spatialdata_plot/pl/utils.py 62.52% <100.00%> (+2.65%) ⬆️

... and 3 files with indirect coverage changes

@timtreis timtreis self-requested a review December 8, 2023 09:23
@timtreis timtreis marked this pull request as ready for review December 8, 2023 09:25
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@timtreis timtreis merged commit 74afb01 into main Dec 8, 2023
3 of 5 checks passed
@timtreis timtreis deleted the bugfix/175-unable-to-plot-shapes branch December 8, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to plot shapes
3 participants