Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.0] feature(pre-commit): replace pylint with ruff #7788

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 30, 2024

Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemented
and we can slow extend its configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE

(cherry picked from commit 8bc05ae)

(cherry picked from commit 418624b)

Parent PR: #5799

@mergify mergify bot added the conflicts label Jun 30, 2024
@mergify mergify bot assigned fruch Jun 30, 2024
Copy link
Author

mergify bot commented Jun 30, 2024

Cherry-pick of 8bc05ae has failed:

On branch mergify/bp/branch-6.0/pr-5799
Your branch is up to date with 'origin/branch-6.0'.

You are currently cherry-picking commit 8bc05ae5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .pre-commit-config.yaml
	modified:   docker/alternator-dns/dns_server.py
	modified:   docker/env/version
	modified:   functional_tests/scylla_operator/conftest.py
	modified:   longevity_test.py
	modified:   mgmt_cli_test.py
	modified:   mgmt_upgrade_test.py
	modified:   performance_regression_row_level_repair_test.py
	new file:   pyproject.toml
	modified:   requirements.in
	modified:   sct.py
	modified:   sdcm/audit.py
	modified:   sdcm/cluster.py
	modified:   sdcm/cluster_aws.py
	modified:   sdcm/cluster_azure.py
	modified:   sdcm/cluster_gce.py
	modified:   sdcm/cluster_k8s/__init__.py
	modified:   sdcm/cluster_k8s/eks.py
	modified:   sdcm/cluster_k8s/gke.py
	modified:   sdcm/cluster_k8s/mini_k8s.py
	modified:   sdcm/coredump.py
	modified:   sdcm/cql_stress_cassandra_stress_thread.py
	modified:   sdcm/db_log_reader.py
	modified:   sdcm/db_stats.py
	modified:   sdcm/ec2_client.py
	modified:   sdcm/fill_db_data.py
	modified:   sdcm/gemini_thread.py
	modified:   sdcm/mgmt/cli.py
	modified:   sdcm/mgmt/operator.py
	modified:   sdcm/monitorstack/__init__.py
	modified:   sdcm/nemesis.py
	modified:   sdcm/prometheus.py
	modified:   sdcm/provision/azure/ip_provider.py
	modified:   sdcm/provision/azure/network_interface_provider.py
	modified:   sdcm/provision/azure/virtual_machine_provider.py
	modified:   sdcm/provision/azure/virtual_network_provider.py
	modified:   sdcm/provision/scylla_yaml/scylla_yaml.py
	modified:   sdcm/remote/libssh2_client/exceptions.py
	modified:   sdcm/results_analyze/__init__.py
	modified:   sdcm/results_analyze/test.py
	modified:   sdcm/sct_config.py
	modified:   sdcm/sct_events/events_processes.py
	modified:   sdcm/sct_runner.py
	modified:   sdcm/send_email.py
	modified:   sdcm/stress/latte_thread.py
	modified:   sdcm/stress_thread.py
	modified:   sdcm/tester.py
	modified:   sdcm/utils/cdc/options.py
	modified:   sdcm/utils/common.py
	modified:   sdcm/utils/data_validator.py
	modified:   sdcm/utils/docker_utils.py
	modified:   sdcm/utils/gce_utils.py
	modified:   sdcm/utils/get_username.py
	modified:   sdcm/utils/k8s/__init__.py
	modified:   sdcm/utils/k8s/chaos_mesh.py
	modified:   sdcm/utils/latency.py
	modified:   sdcm/utils/ldap.py
	modified:   sdcm/utils/log.py
	modified:   sdcm/utils/microbenchmarking/perf_simple_query_reporter.py
	modified:   sdcm/utils/properties.py
	modified:   sdcm/utils/remote_logger.py
	modified:   sdcm/utils/sstable/sstable_utils.py
	modified:   sdcm/utils/toppartition_util.py
	modified:   sdcm/utils/version_utils.py
	modified:   sdcm/ycsb_thread.py
	modified:   sla_per_user_system_test.py
	modified:   unit_tests/lib/fake_provisioner.py
	modified:   unit_tests/provisioner/fake_azure_service.py
	modified:   unit_tests/test_sct_events_base.py
	modified:   unit_tests/test_version_utils.py
	modified:   upgrade_schema_test.py
	modified:   upgrade_test.py
	modified:   utils/build_system/create_test_release_jobs.py
	modified:   utils/cloud_cleanup/azure/clean_azure.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   requirements.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft June 30, 2024 09:22
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
(cherry picked from commit 8bc05ae)
@fruch fruch force-pushed the mergify/bp/branch-6.0/pr-5799 branch from 7da75d5 to 4a7efdc Compare June 30, 2024 09:25
@fruch fruch marked this pull request as ready for review June 30, 2024 09:26
@fruch fruch requested review from soyacz and vponomaryov June 30, 2024 09:26
@fruch fruch removed the conflicts label Jun 30, 2024
@fruch fruch force-pushed the mergify/bp/branch-6.0/pr-5799 branch from 4a7efdc to 61faf1f Compare June 30, 2024 10:11
@fruch fruch merged commit 52e7bc9 into branch-6.0 Jun 30, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/branch-6.0/pr-5799 branch June 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant