Merging in capacity for advanced features #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff for now. Also temporarily defaulting altitudeMultiplier to 0.7, which causes some hitches, but makes it easier to evaluate markers.
… from new pre-set altitude multiplier.
…and there are content-related issues with a good number of the NWIS charts and with the link format for the first link on the WQP sites.
…ng on regions without WaDE sites (or other kinds of sites). Sort of a bandaid solution right now where it just returns null and then doesn't plot anything if the featureset is null. Not the cleanest way to do it and will require some changes to do things like sub in different kinds of sites in California or keep non-existent site types off the legends (at least just some filtering in the legend creation).
…te headers wasn't working perfectly, so I'm pulling data from state-by-state XML files that describe active sites. Wrote a method to do it on load, but it adds like an extra five seconds to the load time and apparently it only needs to be refreshed every month or so, so I just pasted it into a hard-coded JSON. I'll either write a script to update this monthly or just do it manually. Styling is still pretty icky, but that can be fixed later.
…the styling a little.
… on click. This needs to be a little re-styled and maybe re-positioned and the naming of the site types will probably need to be updated as well, with feedback from the IOW team.
…city of the other control/nav boxes.
… removed some outdated code.
…ssing step, if there are CA gages.
…dizing font sizes/families, adding a load spinner for NWIS image waits, and trying to get the title casing on site names as close to accurate as possible, making them much less of an eye sore and much more legible.
…ld code, not pushing yet.
…hang due to a renaming of the NWIS site 'source' attribute 2) Added a datafile from Kyle with flowlevels by flowline comid. The size has been reduced to ~30MB, but we may need to get creative about shrinking it further. It's not in use yet, but will be soon for... 3) Added a small threejs widget (and a retired alt widget that I just want to commit to the repo for now) for tracking water level. It's a bit of an iteration on the 'bucket' idea, instead using a small stone container that lresembles a riverbed a little more in material and has a consistent width to accurately represent volume. Right now, it mostly works at adjusting water level dynamically, but has a few small issues and isn't yet hooked up to the actual flow level data. I'll do all this next so for now it's just a shiny widget in the way that isn't doing anything.
…rue/fixed caustics on bucket simulation, changed texture to plastic vs. stone (for now, at least). Hooked up flowrate to bucket simulation, as well. Setting a global maxiumum at 20,000 cubic feet/second, which is then overwritten if the flowpath has a higher max value.
Updating WQP links and making some small correction/viz state changes on flow gauge
…nt geocoder issues (also turned a select() into a selectAll() just in case, since the bug was causing multiple instances). Did a bunch of refactoring to cut out about a third of the size of the massive Map.svelte file. Tried to move things that were not directly related to the state of the component out, probably a little more that can be done, but it's probably going to be a ~1000 line component regardless.
… commit the changes...
… handling for the CA Gage link responses, since those responses are now throwing other errors besides just bad status codes.
…ted for ticks in the precalculateInitialCamera method.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/samlearner/river-runner/745AUmMC2b3fWbhp9fyv19pGTSxV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work fixes some minor bugs, but also makes it possible to enable NLDI/geoconnex sites on the map, as well as tracking flowrates. Right now, these features are defaulted to off, and there's no way to switch them on, but that could eventually change if I add an options box UI item.