Removes lint R0201 (#369)

* Removes lint R0201

* code coverage

* lint

* Update os_helper.py

Author: xadupre

_doc/sphinxdoc/source/conf.py

@@ -12,19 +12,14 @@
 from pyquickhelper.helpgen.default_conf import set_sphinx_variables
 
 
-def callback_begin():
-    print("[sphinx.conf.py] documentation started.")
-
-
 set_sphinx_variables(__file__, "pyquickhelper", "Xavier Dupré", 2022,
                      "alabaster", alabaster.get_path(),
                      locals(),
                      github_repo="https://github.com/sdpython/pyquickhelper.git",
                      extlinks=dict(issue=(
                          'https://github.com/sdpython/pyquickhelper/issues/%s',
                          'issue ')),
-                     link_resolve="http://www.xavierdupre.fr/app/",
-                     callback_begin=callback_begin)
+                     link_resolve="http://www.xavierdupre.fr/app/")
 
 # there is an issue with this attribute on Anaconda math_number_all
 assert math_number_all or not math_number_all

_unittests/ut_helpgen/test_missing_function_helpgen.py

@@ -6,7 +6,6 @@
 import sys
 import os
 import unittest
-
 from pyquickhelper.pycode import ExtTestCase, skipif_vless, skipif_azure, skipif_appveyor
 from pyquickhelper.helpgen.utils_sphinx_config import NbImage
 from pyquickhelper.helpgen.post_process import remove_character_under32
@@ -18,13 +17,20 @@
 from pyquickhelper.helpgen.sphinx_helper import everything_but_python
 from pyquickhelper.helpgen.rst_converters import correct_indentation
 from pyquickhelper.helpgen.sphinxm_mock_app import MockSphinxApp
+from pyquickhelper.helpgen.utils_sphinx_config import _NbImage, getsitepackages
+from pyquickhelper.helpgen.sphinx_main_verification import SphinxVerificationException
+from pyquickhelper.helpgen.helpgen_exceptions import HelpGenException
 
 
 class TestMissingFunctionsHelpgen(ExtTestCase):
 
     def test_nb_image(self):
         r = NbImage("completion.png")
         self.assertTrue(r is not None)
+        self.assertRaise(lambda: NbImage("_completion.png"), FileNotFoundError)
+        self.assertRaise(lambda: _NbImage("_completion.png"), FileNotFoundError)
+        r = _NbImage("completion.png")
+        self.assertTrue(r is not None)
 
     def test_remove_character_under32(self):
         s = "a\na\r"
@@ -93,6 +99,16 @@ def test_correct_indentation(self):
         ded = text.replace("            ", "")
         self.assertEqual(ded.strip(" \n\r"), new_text.strip(" \n\r"))
 
+    def test_getsitepackages(self):
+        res = getsitepackages()
+        self.assertIsInstance(res, list)
+
+    def test_SphinxVerificationException(self):
+        exc = SphinxVerificationException([])
+        self.assertNotEmpty(exc)
+        exc = HelpGenException('msg')
+        self.assertNotEmpty(exc)
+
 
 if __name__ == "__main__":
     unittest.main()

_unittests/ut_loghelper/test_missing.py

@@ -2,38 +2,31 @@
 @brief      test tree node (time=1s)
 """
 
-
 import sys
 import os
 import unittest
-
-from pyquickhelper.loghelper.flog import fLOG, IsEmptyString
+from pyquickhelper.pycode import ExtTestCase
+from pyquickhelper.loghelper.flog import IsEmptyString
 from pyquickhelper.loghelper.pqh_exception import PQHException
+from pyquickhelper.loghelper.os_helper import get_machine
 
 
-class TestMissing(unittest.TestCase):
+class TestMissing(ExtTestCase):
 
     def test_exception(self):
-        fLOG(
-            __file__,
-            self._testMethodName,
-            OutputPrint=__name__ == "__main__")
-
         try:
             raise PQHException("error", True)
         except PQHException:
             pass
 
     def test_is_missing(self):
-        fLOG(
-            __file__,
-            self._testMethodName,
-            OutputPrint=__name__ == "__main__")
-
         assert IsEmptyString("")
         assert IsEmptyString(None)
         assert not IsEmptyString("-")
 
+    def test_get_machine(self):
+        self.assertIsInstance(get_machine(), str)
+
 
 if __name__ == "__main__":
     unittest.main()

_unittests/ut_pycode/test_LONG_full_unit_test_module_template.py

@@ -83,7 +83,7 @@ def skip_function(name, code, duration):
             for command in ["version", "write_version", "clean_pyd",
                             "build_script", "copy27",
                             "run_pylint .*((myex)|(example_ext)).*[.]py$ "
-                            "-iC0103 -iR0201 -iC0123 -iC0111 -iW0611 -iE0401 -iE0611 -iE0401",
+                            "-iC0103 -iC0123 -iC0111 -iW0611 -iE0401 -iE0611 -iE0401",
                             "unittests -e .*code_style.*",
                             "unittests -g .*((ext)|(code_style)|(run_notebooks)).*",
                             "unittests_LONG", "unittests_SKIP",

_unittests/ut_pycode/test_check_pep8_sample.py

@@ -34,7 +34,7 @@ def check_pep8_one_file():
 
         def check_pep8_error_file():
             check_pep8(this, recursive=False,
-                       pylint_ignore=('C0111', 'R0201', 'C0103'),
+                       pylint_ignore=('C0111', 'C0103'),
                        pattern="test_check_pep8_sample.py",
                        neg_pattern="##",
                        skip=["test_check_pep8_sample.py:15",

src/pyquickhelper/filehelper/anyfhelper.py

@@ -95,7 +95,7 @@ def change_file_status(folder, status=stat.S_IWRITE, strict=False,
                             res.append(d)
                 try:
                     mode = os.stat(f).st_mode
-                except FileNotFoundError:
+                except FileNotFoundError:  # pragma: no cover
                     # it appends for some weird path
                     warnings.warn(
                         "[change_file_status] unable to find '{0}'".format(f), UserWarning)

src/pyquickhelper/filehelper/download_helper.py

@@ -13,7 +13,7 @@
 import http.client as http_client
 try:
     from http.client import InvalidURL
-except ImportError:
+except ImportError:  # pragma: no cover
     InvalidURL = ValueError
 
 
@@ -93,51 +93,17 @@ def _local_loop(ur):
             else:
                 with urllib_request.urlopen(url) as ur:
                     res = ur.read()
-    except (urllib_error.HTTPError, urllib_error.URLError,
-            ConnectionRefusedError) as e:
-        if raise_exception:
-            raise InternetException(
-                "Unable to retrieve content, url='{0}'".format(url)) from e
-        warnings.warn(
-            "Unable to retrieve content from '{0}' exc: {1}".format(url, e), ResourceWarning)
-        return None
-    except socket.timeout as e:
-        if raise_exception:
-            raise InternetException(
-                "Unable to retrieve content, url='{0}'".format(url)) from e
-        warnings.warn("unable to retrieve content from {0} because of timeout {1}: {2}".format(
-            url, timeout, e), ResourceWarning)
-        return None
-    except ConnectionResetError as e:
-        if raise_exception:
-            raise InternetException(
-                "Unable to retrieve content, url='{0}'".format(url)) from e
-        warnings.warn(
-            "unable to retrieve content from {0} because of ConnectionResetError: {1}".format(url, e), ResourceWarning)
-        return None
-    except http_client.BadStatusLine as e:
-        if raise_exception:
-            raise InternetException(
-                "Unable to retrieve content, url='{0}'".format(url)) from e
-        warnings.warn(
-            "Unable to retrieve content from '{0}' because of http.client.BadStatusLine: {1}".format(url, e), ResourceWarning)
-        return None
-    except http_client.IncompleteRead as e:
-        if raise_exception:
-            raise InternetException(
-                "Unable to retrieve content url='{0}'".format(url)) from e
-        warnings.warn(
-            "Unable to retrieve content from '{0}' because of http.client.IncompleteRead: {1}".format(url, e), ResourceWarning)
-        return None
-    except (ValueError, InvalidURL) as e:
+    except (urllib_error.HTTPError, urllib_error.URLError, ConnectionRefusedError,
+            socket.timeout, ConnectionResetError, http_client.BadStatusLine,
+            http_client.IncompleteRead, ValueError, InvalidURL) as e:
         if raise_exception:
             raise InternetException(
                 "Unable to retrieve content url='{0}'".format(url)) from e
         warnings.warn(
             "Unable to retrieve content from '{0}' because of {1}".format(url, e), ResourceWarning)
         return None
     except Exception as e:
-        if raise_exception:
+        if raise_exception:  # pragma: no cover
             raise InternetException(
                 "Unable to retrieve content, url='{0}', exc={1}".format(url, e)) from e
         warnings.warn(
@@ -152,7 +118,7 @@ def _local_loop(ur):
         if encoding is not None:
             try:
                 content = res.decode(encoding)
-            except UnicodeDecodeError as e:
+            except UnicodeDecodeError as e:  # pragma: no cover
                 # it tries different encoding
 
                 laste = [e]

src/pyquickhelper/filehelper/encrypted_backup.py

@@ -198,7 +198,7 @@ def enumerate_read_encrypt(self, fullname):
             try:
                 data = f.read(self._threshold_size)
                 cont = True
-            except PermissionError as e:
+            except PermissionError as e:  # pragma: no cover
                 yield e
                 cont = False
             if cont:
@@ -209,7 +209,7 @@ def enumerate_read_encrypt(self, fullname):
                     yield enc
                     try:
                         data = f.read(self._threshold_size)
-                    except PermissionError as e:
+                    except PermissionError as e:  # pragma: no cover
                         yield e
                         cont = False
 
@@ -226,14 +226,14 @@ def compress(self, data):
             # delay import
             try:
                 import lzma
-            except ImportError:
+            except ImportError:  # pragma: no cover
                 import pylzma as lzma
             return lzma.compress(data)
         elif self._compress is None:
             return data
         else:
-            raise ValueError(
-                "unexpected compression algorithm {0}".format(self._compress))
+            raise ValueError(  # pragma: no cover
+                "Unexpected compression algorithm '{0}'.".format(self._compress))
 
     def decompress(self, data):
         """
@@ -248,14 +248,14 @@ def decompress(self, data):
             # delay import
             try:
                 import lzma
-            except ImportError:
+            except ImportError:  # pragma: no cover
                 import pylzma as lzma
             return lzma.decompress(data)
         elif self._compress is None:
             return data
         else:
-            raise ValueError(
-                "unexpected compression algorithm {0}".format(self._compress))
+            raise ValueError(  # pragma: no cover
+                "Unexpected compression algorithm '{0}'.".format(self._compress))
 
     def start_transfering(self):
         """
@@ -278,8 +278,9 @@ def start_transfering(self):
                           (i, len(total), sum_bytes))
             relp = os.path.relpath(file.fullname, self._root_local)
             if ".." in relp:
-                raise ValueError("the local root is not accurate:\n{0}\nFILE:\n{1}\nRELPATH:\n{2}".format(
-                    self, file.fullname, relp))
+                raise ValueError(  # pragma: no cover
+                    "The local root is not accurate:\n{0}\nFILE:\n{1}\nRELPATH:\n{2}".format(
+                        self, file.fullname, relp))
 
             path = self._root_remote + "/" + os.path.split(relp)[0]
             path = path.replace("\\", "/")
@@ -317,8 +318,9 @@ def start_transfering(self):
                 issues.append((relp, err))
 
             if len(issues) >= 5:
-                raise EncryptedBackupError("too many issues:\n{0}".format(
-                    "\n".join("{0} -- {1}".format(a, b) for a, b in issues)))
+                raise EncryptedBackupError(  # pragma: no cover
+                    "Too many issues:\n{0}".format(
+                        "\n".join("{0} -- {1}".format(a, b) for a, b in issues)))
 
         self.transfer_mapping()
         return done, issues
@@ -343,11 +345,11 @@ def retrieve(self, path, filename=None, root=None):
         @return                 filename or data
         """
         if self.Mapping is None:
-            raise EncryptedBackupError(
-                "load the mapping with method load_mapping")
+            raise EncryptedBackupError(  # pragma: no cover
+                "Load first the mapping with method load_mapping.")
         if path not in self.Mapping:
-            raise EncryptedBackupError(
-                "the mapping is not up to date or file {0} cannot be found".format(path))
+            raise EncryptedBackupError(  # pragma: no cover
+                "The mapping is not up to date or file '{0}' cannot be found.".format(path))
         info = self.Mapping[path]
         if len(info.pieces) == 0:
             # the file is empty

src/pyquickhelper/filehelper/file_tree_node.py

@@ -92,7 +92,8 @@ def __init__(self, root, file=None, filter=None, level=0, parent=None,
         @param      fLOG            logging function to use
         """
         if root is None:
-            raise ValueError("root cannot be None")
+            raise ValueError(  # pragma: no cover
+                "root cannot be None.")
         self._root = root
         self._file = None if file is None else file
         self._children = []
@@ -109,12 +110,14 @@ def __init__(self, root, file=None, filter=None, level=0, parent=None,
         if not os.path.exists(root):
             raise PQHException("path '%s' does not exist" % root)
         if not os.path.isdir(root):
-            raise PQHException("path '%s' is not a folder" % root)
+            raise PQHException(  # pragma: no cover
+                "path '%s' is not a folder" % root)
 
         if self._file is not None:
             if not self.exists():
-                raise PQHException(
-                    "%s does not exist [%s,%s]" % (self.get_fullname(), root, file))
+                raise PQHException(  # pragma: no cover
+                    "%s does not exist [%s,%s]" % (
+                        self.get_fullname(), root, file))
 
         self._fillstat()
         if self.isdir():
@@ -277,8 +280,9 @@ def _fill(self, filter, repository):
         @param      repository  use svn or git
         """
         if not self.isdir():
-            raise PQHException(
-                "unable to look into a file %s full %s" % (self._file, self.get_fullname()))
+            raise PQHException(  # pragma: no cover
+                "Unable to look into a file %r full %r." % (
+                    self._file, self.get_fullname()))
 
         if repository:
             opt = "repo_ls"
@@ -309,7 +313,7 @@ def _fill(self, filter, repository):
                     n = FileTreeNode(self._root, os.path.join(fi, a), filter, level=self._level + 1,
                                      parent=self, repository=repository, log=self._log,
                                      log1=self._log1 or self._log, fLOG=self.fLOG)
-                except PQHException as e:
+                except PQHException as e:  # pragma: no cover
                     if "does not exist" in str(e):
                         self.fLOG(
                             "a folder should exist, but is it is not, it continues [opt=%s]" % opt)
@@ -475,7 +479,7 @@ def remove(self):
         self.fLOG("removing ", full)
         try:
             os.remove(full)
-        except OSError as e:
+        except OSError as e:  # pragma: no cover
             self.fLOG(
                 "unable to remove ", full, " --- ", str(e).replace("\n", " "))
             self.fLOG("[pyqerror] ", e)
@@ -494,10 +498,11 @@ def copy_to(self, path, exc=True):
                  the new file is older.
         """
         if not os.path.exists(path):
-            raise PQHException("this path does not exist: '{0}'".format(path))
+            raise PQHException(  # pragma: no cover
+                "This path does not exist: '{0}'.".format(path))
         if self.isdir():
-            raise PQHException(
-                "this node represents a folder " + self.get_fullname())
+            raise PQHException(  # pragma: no cover
+                "This node represents a folder %r." % self.get_fullname())
         full = self.get_fullname()
         temp = os.path.split(self._file)[0]
         dest = os.path.join(path, temp)
@@ -522,7 +527,7 @@ def copy_to(self, path, exc=True):
                 if t1 > t2 and exc:
                     raise PQHException(mes)
                 warnings.warn(mes, RuntimeWarning)
-        except OSError as e:
+        except OSError as e:  # pragma: no cover
             # else :
             self.fLOG("unable to copy file ", full, " to ", path)
             self.fLOG("[pyqerror]", e)